Staging: rt2870: Don't call sprintf() with overlapping input and output.
authorAnders Kaseorg <andersk@MIT.EDU>
Tue, 24 Mar 2009 20:41:55 +0000 (16:41 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 19 Jun 2009 18:00:36 +0000 (11:00 -0700)
commit2fefd5f6688deaaac96497426677ef1333b5982b
treebed79e3a3a6114b29a795b192a33d57b42bd0f92
parent32c976bca43814be70d6062885be80673ffd66fc
Staging: rt2870: Don't call sprintf() with overlapping input and output.

The use of sprintf() to append to a buffer, as in
  sprintf(buf, "%sEntry: %d\n", buf, i)
is not valid according to C99 ("If copying takes place between objects
that overlap, the behavior is undefined.").  It breaks at least in
userspace under gcc -D_FORTIFY_SOURCE.  Replace this construct with
  sprintf(buf + strlen(buf), "Entry: %d\n", i)

This patch was automatically generated using
  perl -0pe 's/(sprintf\s*\(\s*([^,]*))(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3$4/g'
  perl -0pe 's/(snprintf\s*\(\s*([^,]*))(\s*,[^,]*?)(\s*,\s*")%s((?:[^"\\]|\\.)*"\s*,)\s*\2\s*,/$1 + strlen($2)$3 - strlen($2)$4$5/g'

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/rt2870/common/cmm_info.c
drivers/staging/rt2870/sta/assoc.c
drivers/staging/rt2870/sta_ioctl.c