Btrfs: should add a permission check for setfacl
authorShi Weihua <shiwh@cn.fujitsu.com>
Tue, 18 May 2010 00:50:32 +0000 (00:50 +0000)
committerChris Mason <chris.mason@oracle.com>
Fri, 11 Jun 2010 19:57:37 +0000 (15:57 -0400)
commit2f26afba46f0ebf155cf9be746496a0304a5b7cf
tree8127a4a101734efce3c0d0190754f180de05a599
parentcf1e99a4e0daa4a5623cd71108509823b9ff2d30
Btrfs: should add a permission check for setfacl

On btrfs, do the following
------------------
# su user1
# cd btrfs-part/
# touch aaa
# getfacl aaa
  # file: aaa
  # owner: user1
  # group: user1
  user::rw-
  group::rw-
  other::r--
# su user2
# cd btrfs-part/
# setfacl -m u::rwx aaa
# getfacl aaa
  # file: aaa
  # owner: user1
  # group: user1
  user::rwx           <- successed to setfacl
  group::rw-
  other::r--
------------------
but we should prohibit it that user2 changing user1's acl.
In fact, on ext3 and other fs, a message occurs:
  setfacl: aaa: Operation not permitted

This patch fixed it.
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
fs/btrfs/acl.c