netpoll: fix NULL pointer dereference in netpoll_cleanup
authorNikolay Aleksandrov <nikolay@redhat.com>
Thu, 19 Sep 2013 13:02:35 +0000 (15:02 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:08 +0000 (21:06 +0100)
commit2eb90b30797b3c908b597e4a2a700d6ef9ae0196
tree09e141d0c5795c264cdfce3f165aac29db34d9f4
parent836f6cb46716e36cb8d31a402c6661af5c895135
netpoll: fix NULL pointer dereference in netpoll_cleanup

[ Upstream commit d0fe8c888b1fd1a2f84b9962cabcb98a70988aec ]

I've been hitting a NULL ptr deref while using netconsole because the
np->dev check and the pointer manipulation in netpoll_cleanup are done
without rtnl and the following sequence happens when having a netconsole
over a vlan and we remove the vlan while disabling the netconsole:
CPU 1 CPU2
removes vlan and calls the notifier
enters store_enabled(), calls
netdev_cleanup which checks np->dev
and then waits for rtnl
executes the netconsole netdev
release notifier making np->dev
== NULL and releases rtnl
continues to dereference a member of
np->dev which at this point is == NULL

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/netpoll.c