dccp: fix info leak via getsockopt(DCCP_SOCKOPT_CCID_TX_INFO)
authorMathias Krause <minipli@googlemail.com>
Wed, 15 Aug 2012 11:31:55 +0000 (11:31 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 19 Sep 2012 14:04:53 +0000 (15:04 +0100)
commit24635bcd494892f4fce7b2504f3f1c65cc2d6ad2
treea9db48e29c21fcd04e02ceafb396bf8e0e3aa6ab
parent3f497daadeeb2b84dc8e97b32416d98b34485b99
dccp: fix info leak via getsockopt(DCCP_SOCKOPT_CCID_TX_INFO)

[ Upstream commit 7b07f8eb75aa3097cdfd4f6eac3da49db787381d ]

The CCID3 code fails to initialize the trailing padding bytes of struct
tfrc_tx_info added for alignment on 64 bit architectures. It that for
potentially leaks four bytes kernel stack via the getsockopt() syscall.
Add an explicit memset(0) before filling the structure to avoid the
info leak.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/dccp/ccids/ccid3.c