net: Kill skb_truesize_check(), it only catches false-positives.
authorDavid S. Miller <davem@davemloft.net>
Thu, 26 Feb 2009 07:09:34 +0000 (23:09 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 17 Mar 2009 00:52:42 +0000 (17:52 -0700)
commit21ef40e66f6186898ea4240b83a0f1c7424953d0
treef8cd7f28a308c33114c8988c0ce3638ec958158e
parenta6fa7047cf5cb20353178e9b31c3105f13461b54
net: Kill skb_truesize_check(), it only catches false-positives.

[ Upstream commit 92a0acce186cde8ead56c6915d9479773673ea1a ]

A long time ago we had bugs, primarily in TCP, where we would modify
skb->truesize (for TSO queue collapsing) in ways which would corrupt
the socket memory accounting.

skb_truesize_check() was added in order to try and catch this error
more systematically.

However this debugging check has morphed into a Frankenstein of sorts
and these days it does nothing other than catch false-positives.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/skbuff.h
include/net/sock.h
net/core/skbuff.c
net/core/sock.c