sched: Fix race on toggling cfs_bandwidth_used
authorBen Segall <bsegall@google.com>
Wed, 16 Oct 2013 18:16:12 +0000 (11:16 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 29 Oct 2013 11:02:19 +0000 (12:02 +0100)
commit1ee14e6c8cddeeb8a490d7b54cd9016e4bb900b4
tree1fe48f0122fdda3bf75bb637a9e103e541598e8a
parentac9ff7997b6f2b31949dcd2495ac671fd9ddc990
sched: Fix race on toggling cfs_bandwidth_used

When we transition cfs_bandwidth_used to false, any currently
throttled groups will incorrectly return false from cfs_rq_throttled.
While tg_set_cfs_bandwidth will unthrottle them eventually, currently
running code (including at least dequeue_task_fair and
distribute_cfs_runtime) will cause errors.

Fix this by turning off cfs_bandwidth_used only after unthrottling all
cfs_rqs.

Tested: toggle bandwidth back and forth on a loaded cgroup. Caused
crashes in minutes without the patch, hasn't crashed with it.

Signed-off-by: Ben Segall <bsegall@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: pjt@google.com
Link: http://lkml.kernel.org/r/20131016181611.22647.80365.stgit@sword-of-the-dawn.mtv.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c
kernel/sched/fair.c
kernel/sched/sched.h