HID: validate HID report id size
authorKees Cook <keescook@chromium.org>
Wed, 28 Aug 2013 20:29:55 +0000 (22:29 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:00 +0000 (21:06 +0100)
commit1ccd1fd4c43407721caa38ae034359bf8d9a1b34
tree161255925d7a0b776cffbf437dedcc2672a6a595
parent934796aadc4cf907d21b9346b70383d520bd0eea
HID: validate HID report id size

commit 43622021d2e2b82ea03d883926605bdd0525e1d1 upstream.

The "Report ID" field of a HID report is used to build indexes of
reports. The kernel's index of these is limited to 256 entries, so any
malicious device that sets a Report ID greater than 255 will trigger
memory corruption on the host:

[ 1347.156239] BUG: unable to handle kernel paging request at ffff88094958a878
[ 1347.156261] IP: [<ffffffff813e4da0>] hid_register_report+0x2a/0x8b

CVE-2013-2888

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[bwh: Backported to 3.2: use dbg_hid() not hid_err()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hid/hid-core.c
include/linux/hid.h