aio: add missing smp_rmb() in read_events_ring
authorJeff Moyer <jmoyer@redhat.com>
Tue, 2 Sep 2014 17:17:00 +0000 (13:17 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 5 Nov 2014 20:27:40 +0000 (20:27 +0000)
commit1cc8e21690688b24b0b9388dbb14e1d2cf4f94b4
tree66c1fbf3c45571f78bb1b4c907f134affada8f0c
parent11d3b506cc0db26d2f2078bd4df88803cd06c819
aio: add missing smp_rmb() in read_events_ring

commit 2ff396be602f10b5eab8e73b24f20348fa2de159 upstream.

We ran into a case on ppc64 running mariadb where io_getevents would
return zeroed out I/O events.  After adding instrumentation, it became
clear that there was some missing synchronization between reading the
tail pointer and the events themselves.  This small patch fixes the
problem in testing.

Thanks to Zach for helping to look into this, and suggesting the fix.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
[bwh: Backported to 3.2: adjust context, indentation]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/aio.c