ext4: fix memory leak in ext4_free_branches
authorTheodore Ts'o <tytso@mit.edu>
Mon, 10 Jan 2011 17:51:28 +0000 (12:51 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 10 Jan 2011 17:51:28 +0000 (12:51 -0500)
commit1c5b9e9065567876c2d4a7a16d78f0fed154a5bf
tree67b74f12c7336a972de54d004455369eec38bc28
parenta5196f8cdfbf6ccb20f093aaf48852d6d23b4e0b
ext4: fix memory leak in ext4_free_branches

Commit 40389687 moved a call to ext4_forget() out of
ext4_free_branches and let ext4_free_blocks() handle calling
bforget().  But that change unfortunately did not replace the call to
ext4_forget() with brelse(), which was needed to drop the in-use count
of the indirect block's buffer head, which lead to a memory leak when
deleting files that used indirect blocks.  Fix this.

Thanks to Hugh Dickins for pointing this out.

Cc: stable@kernel.org
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c