openvswitch: packet messages need their own probe attribtue
authorThomas Graf <tgraf@suug.ch>
Wed, 14 Jan 2015 13:56:19 +0000 (13:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Jan 2015 21:49:44 +0000 (16:49 -0500)
commit1ba398041f5b5a15456ea20a9ba3ff80b6a4e7d1
tree11d8bc5cd83cdad417a1c4d5863a756023480f1d
parent776d4e9f5c0229037707f692b386b1f2a5bac054
openvswitch: packet messages need their own probe attribtue

User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
and packet messages. This leads to an out-of-bounds access in
ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
OVS_PACKET_ATTR_MAX.

Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.

Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Tracked-down-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Reviewed-by: Jesse Gross <jesse@nicira.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/openvswitch.h
net/openvswitch/datapath.c