xfs: Keep sb_bad_features2 consistent with sb_features2
authorJan Kara <jack@suse.cz>
Tue, 23 Dec 2014 22:48:35 +0000 (09:48 +1100)
committerDave Chinner <david@fromorbit.com>
Tue, 23 Dec 2014 22:48:35 +0000 (09:48 +1100)
commit1a43ec03ddd40793db00dbc7340685f5accf6fc3
treebf2e114db19c9d90b49d93943ec6ddfd526bcf76
parent77af574eef78c404ea630f7955a5ed0c926a63fe
xfs: Keep sb_bad_features2 consistent with sb_features2

Currently when we modify sb_features2, we store the same value also in
sb_bad_features2. However in most places we forget to mark field
sb_bad_features2 for logging and thus it can happen that a change to it
is lost. This results in an inconsistent sb_features2 and
sb_bad_features2 fields e.g. after xfstests test xfs/187.

Fix the problem by changing XFS_SB_FEATURES2 to actually mean both
sb_features2 and sb_bad_features2 fields since this is always what we
want to log. This isn't ideal because the fact that XFS_SB_FEATURES2
means two fields could cause some problem in future however the code is
hopefully less error prone that it is now.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/libxfs/xfs_format.h
fs/xfs/xfs_mount.c