genirq: Prevent potential NULL dereference in irq_set_irq_wake()
authorJesper Juhl <jj@chaosbits.net>
Thu, 9 Jun 2011 21:14:58 +0000 (23:14 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 10 Jun 2011 08:53:42 +0000 (10:53 +0200)
commit13863a66c9c8a663665445cf05d68de96ff31830
treecb7864cf23b6f26f3eb11cfe09526eb7110a0e9a
parent7f45e5cd1718ed769295033ca214032848a0097d
genirq: Prevent potential NULL dereference in irq_set_irq_wake()

In kernel/irq/manage.c::irq_set_irq_wake() we call
irq_get_desc_buslock() which may return NULL, but the code
dereferences the result unconditionally.

irq_set_irq_wake() has lots of callers - I checked a few and I couldn't
find anything that guarantees that they won't call it with some input that
will cause irq_get_desc_buslock() to return NULL, so I think it's a good
thing to test and -EINVAL was the most sane error code in this situation
that I could think of.

Not all callers test the return value of irq_set_irq_wake(), but those
that do take != 0 to mean error as far as I can see, so they should be
fine. I guess those that don't test actually should, but that's a
different issue.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Link: http://lkml.kernel.org/r/alpine.LNX.2.00.1106092300360.17868@swampdragon.chaosbits.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/manage.c