perf_events, x86: Fix validate_event bug
authorStephane Eranian <eranian@google.com>
Tue, 24 Nov 2009 13:27:18 +0000 (05:27 -0800)
committerIngo Molnar <mingo@elte.hu>
Tue, 24 Nov 2009 18:23:48 +0000 (19:23 +0100)
commit1261a02a0c0ab8e643125705f0d1d83e5090e4d1
treef88fb71a8ef8c80c4d9be6bbee9869dd895fb330
parentfcf1203a919c3a3d212c0ed01f5240fd592bf5ae
perf_events, x86: Fix validate_event bug

The validate_event() was failing on valid event combinations. The
function was assuming that if x86_schedule_event() returned 0, it
meant error. But x86_schedule_event() returns the counter index and
0 is a perfectly valid value. An error is returned if the function
returns a negative value.

Furthermore, validate_event() was also failing for event groups
because the event->pmu was not set until after
hw_perf_event_init().

Signed-off-by: Stephane Eranian <eranian@google.com>
Cc: peterz@infradead.org
Cc: paulus@samba.org
Cc: perfmon2-devel@lists.sourceforge.net
Cc: eranian@gmail.com
LKML-Reference: <4b0bdf36.1818d00a.07cc.25ae@mx.google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--
 arch/x86/kernel/cpu/perf_event.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/perf_event.c