nfs: Fix ugly referral attributes
authorChuck Lever <chuck.lever@oracle.com>
Sun, 5 Nov 2017 20:45:22 +0000 (15:45 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Feb 2018 18:32:18 +0000 (18:32 +0000)
commit111dcf9430d8d3dca94fe9e27db5dde81ab0229f
treea89d2f794a78a7cb8a1ee04f166a175afea7970b
parent527a0023ebd56940a3d312d9a2bd759dcac202c4
nfs: Fix ugly referral attributes

commit c05cefcc72416a37eba5a2b35f0704ed758a9145 upstream.

Before traversing a referral and performing a mount, the mounted-on
directory looks strange:

dr-xr-xr-x. 2 4294967294 4294967294 0 Dec 31  1969 dir.0

nfs4_get_referral is wiping out any cached attributes with what was
returned via GETATTR(fs_locations), but the bit mask for that
operation does not request any file attributes.

Retrieve owner and timestamp information so that the memcpy in
nfs4_get_referral fills in more attributes.

Changes since v1:
- Don't request attributes that the client unconditionally replaces
- Request only MOUNTED_ON_FILEID or FILEID attribute, not both
- encode_fs_locations() doesn't use the third bitmask word

Fixes: 6b97fd3da1ea ("NFSv4: Follow a referral")
Suggested-by: Pradeep Thomas <pradeepthomas@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/nfs/nfs4proc.c