rxrpc: bogus MSG_PEEK test in rxrpc_recvmsg()
authorAl Viro <viro@ZenIV.linux.org.uk>
Sat, 14 Mar 2015 05:34:56 +0000 (05:34 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 9 May 2015 22:16:39 +0000 (23:16 +0100)
commit10c82cd7d46e4c525b046c399fcd285ce138198e
treed5c5fdf777403a8bc441cc130b821e1daf3634b3
parent57a2e91f726284b567850ffd29ff5456a25d6abb
rxrpc: bogus MSG_PEEK test in rxrpc_recvmsg()

[ Upstream commit 7d985ed1dca5c90535d67ce92ef6ca520302340a ]

[I would really like an ACK on that one from dhowells; it appears to be
quite straightforward, but...]

MSG_PEEK isn't passed to ->recvmsg() via msg->msg_flags; as the matter of
fact, neither the kernel users of rxrpc, nor the syscalls ever set that bit
in there.  It gets passed via flags; in fact, another such check in the same
function is done correctly - as flags & MSG_PEEK.

It had been that way (effectively disabled) for 8 years, though, so the patch
needs beating up - that case had never been tested.  If it is correct, it's
-stable fodder.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/rxrpc/ar-recvmsg.c