viafb: don't touch clock state on OLPC XO-1.5
authorDaniel Drake <dsd@laptop.org>
Tue, 4 Sep 2012 15:45:32 +0000 (11:45 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 30 Oct 2012 23:26:36 +0000 (23:26 +0000)
commit0b02e6bf9f503004c22206de09589d52fcc5a5db
treed303eb0eef530a3cef8d417d3103e130178b8f44
parentf42ce0ca9eaf8a71f95dd0909c3ade7ab9cd824d
viafb: don't touch clock state on OLPC XO-1.5

commit 012a1211845eab69a5488d59eb87d24cc518c627 upstream.

As detailed in the thread titled "viafb PLL/clock tweaking causes XO-1.5
instability," enabling or disabling the IGA1/IGA2 clocks causes occasional
stability problems during suspend/resume cycles on this platform.

This is rather odd, as the documentation suggests that clocks have two
states (on/off) and the default (stable) configuration is configured to
enable the clock only when it is needed. However, explicitly enabling *or*
disabling the clock triggers this system instability, suggesting that there
is a 3rd state at play here.

Leaving the clock enable/disable registers alone solves this problem.
This fixes spurious reboots during suspend/resume behaviour introduced by
commit b692a63a.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/video/via/via_clock.c