sg_start_req(): make sure that there's not too many elements in iovec
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Mar 2015 00:08:18 +0000 (20:08 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 6 Aug 2015 23:32:04 +0000 (00:32 +0100)
commit07213eed86c17c544bb10568fc04e49e03730ab7
tree7104de2f6e40fa403a19307bb08d29aeb0717f09
parentd6de5ca93fd6425dcdb21cc341365991c0c444cc
sg_start_req(): make sure that there's not too many elements in iovec

commit 451a2886b6bf90e2fb378f7c46c655450fb96e81 upstream.

unfortunately, allowing an arbitrary 16bit value means a possibility of
overflow in the calculation of total number of pages in bio_map_user_iov() -
we rely on there being no more than PAGE_SIZE members of sum in the
first loop there.  If that sum wraps around, we end up allocating
too small array of pointers to pages and it's easy to overflow it in
the second loop.

X-Coverup: TINC (and there's no lumber cartel either)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[bwh: s/MAX_UIOVEC/UIO_MAXIOV/. This was fixed upstream by commit
 fdc81f45e9f5 ("sg_start_req(): use import_iovec()"), but we don't have
 that function.]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/sg.c