[NET] netpoll: break recursive loop in netpoll rx path
authorNeil Horman <nhorman@tuxdriver.com>
Mon, 26 Jun 2006 07:04:27 +0000 (00:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Jun 2006 07:04:27 +0000 (00:04 -0700)
commit068c6e98bc7ec4419299b38cd40be26ebf4bdeda
tree4312d3449036c35d5fc8fd4f60f447200928e817
parent8834807b43200b1658b49d3b779e74a4f77e4ffb
[NET] netpoll: break recursive loop in netpoll rx path

The netpoll system currently has a rx to tx path via:

netpoll_rx
 __netpoll_rx
  arp_reply
   netpoll_send_skb
    dev->hard_start_tx

This rx->tx loop places network drivers at risk of inadvertently causing a
deadlock or BUG halt by recursively trying to acquire a spinlock that is
used in both their rx and tx paths (this problem was origionally reported
to me in the 3c59x driver, which shares a spinlock between the
boomerang_interrupt and boomerang_start_xmit routines).

This patch breaks this loop, by queueing arp frames, so that they can be
responded to after all receive operations have been completed.  Tested by
myself and the reported with successful results.

Specifically it was tested with netdump.  Heres the BZ with details:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194055

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netpoll.h
net/core/netpoll.c