PCI hotplug: fix logic in Compaq hotplug controller bus speed setup
authorJulia Lawall <julia@diku.dk>
Wed, 22 Oct 2008 23:44:00 +0000 (16:44 -0700)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 22 Oct 2008 23:44:00 +0000 (16:44 -0700)
commit05a34f51ba451c65773ad6f1acf4cc089cc474d8
tree4f54ff88ee44c4778a22bbabc48fc2351ffb84e9
parent1388cc964e680c1086ca0edae35be094cb29d51e
PCI hotplug: fix logic in Compaq hotplug controller bus speed setup

The pattern !E && !E->fld is nonsensical.  The patch below updates this
according to the assumption that && should be ||.  But perhaps another
solution was intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@disable and_comm@
expression E;
identifier fld;
@@

- !E && !E->fld
+ !E || !E->fld
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/cpqphp_ctrl.c