workqueue: unfold start_worker() into create_worker()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 22 Jul 2014 05:03:02 +0000 (13:03 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 22 Jul 2014 16:10:39 +0000 (12:10 -0400)
commit051e1850106687896d4c4eeaf6ae4d61c4862e85
tree4c0777d0dd4cb9179b31944a40b7fb843335ef84
parent228f1d0018ba6b24c9f718a97a5bc35b24f1e1e3
workqueue: unfold start_worker() into create_worker()

Simply unfold the code of start_worker() into create_worker() and
remove the original start_worker() and create_and_start_worker().

The only trade-off is the introduced overhead that the pool->lock
is released and regrabbed after the newly worker is started.
The overhead is acceptible since the manager is slow path.

And because this new locking behavior, the newly created worker
may grab the lock earlier than the manager and go to process
work items. In this case, the recheck need_to_create_worker() may be
true as expected and the manager goes to restart which is the
correct behavior.

tj: Minor updates to description and comments.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c