mm: pass correct mm when growing stack
authorHugh Dickins <hugh@veritas.com>
Thu, 16 Apr 2009 20:58:12 +0000 (21:58 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 20 Aug 2010 18:25:12 +0000 (11:25 -0700)
commit01ee2e1e3041f41722ef3ae49e95f04086dbd320
tree5414effbde9473d5e6a6a3e435f51e2b30d84920
parenta980300e27c138836e2cc515e53f83e4d1a0505b
mm: pass correct mm when growing stack

commit 05fa199d45c54a9bda7aa3ae6537253d6f097aa9 upstream.

Tetsuo Handa reports seeing the WARN_ON(current->mm == NULL) in
security_vm_enough_memory(), when do_execve() is touching the
target mm's stack, to set up its args and environment.

Yes, a UMH_NO_WAIT or UMH_WAIT_PROC call_usermodehelper() spawns
an mm-less kernel thread to do the exec.  And in any case, that
vm_enough_memory check when growing stack ought to be done on the
target mm, not on the execer's mm (though apart from the warning,
it only makes a slight tweak to OVERCOMMIT_NEVER behaviour).

Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
mm/mmap.c