KEYS: Fix stale key registration at error path
authorTakashi Iwai <tiwai@suse.de>
Thu, 4 Dec 2014 17:25:19 +0000 (18:25 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:29 +0000 (00:49 +0000)
commit655f4c99e1b105fe481f254ed1cb7af0ba64f550
treef7862c95a740c7266adc35febffd71278774d4ef
parentd143bd76bf12b65e61c55aa42e05a0b51e205077
KEYS: Fix stale key registration at error path

commit b26bdde5bb27f3f900e25a95e33a0c476c8c2c48 upstream.

When loading encrypted-keys module, if the last check of
aes_get_sizes() in init_encrypted() fails, the driver just returns an
error without unregistering its key type.  This results in the stale
entry in the list.  In addition to memory leaks, this leads to a kernel
crash when registering a new key type later.

This patch fixes the problem by swapping the calls of aes_get_sizes()
and register_key_type(), and releasing resources properly at the error
paths.

Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=908163
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
security/keys/encrypted-keys/encrypted.c