git.openpandora.org / pandora-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fe9ab00) | patch
params: Fix potential memory leak in add_sysfs_param()
authorDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 14 Mar 2013 13:23:11 +0000 (13:23 +0000)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 18 Mar 2013 11:40:21 +0000 (11:40 +0000)
commit63662139e519ce06090b2759cf4a1d291b9cc0e2
tree65fe475f0f13719da4f78a85d44116a5c23ba7d1tree | snapshot
parentfe9ab00f8354a4c388e30301859c5741590c3809commit | diff
params: Fix potential memory leak in add_sysfs_param()

On allocation failure, it would fail to free the old attrs array which
was no longer referenced by anything (since it would free the old
module_param_attrs struct on the way out).

Comment the suspicious-looking krealloc() usage to explain why it *isn't*
actually buggy, despite looking like a classic realloc() usage bug.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
kernel/params.c diff | blob | history
Pandora Kernel Repository