staging: goldfish: Call free_irq in error path
authorTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Tue, 8 Apr 2014 06:15:22 +0000 (09:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Apr 2014 18:41:44 +0000 (11:41 -0700)
If misc_register failed in goldfish_audio_probe, the already requested
IRQ wouldn't get freed. Add a call to free_irq() like there is in
goldfish_audio_remove().

Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/goldfish/goldfish_audio.c

index f96dcec..7ac2602 100644 (file)
@@ -334,6 +334,7 @@ static int goldfish_audio_probe(struct platform_device *pdev)
        return 0;
 
 err_misc_register_failed:
+       free_irq(data->irq, data);
 err_request_irq_failed:
        dma_free_coherent(&pdev->dev, COMBINED_BUFFER_SIZE,
                                        data->buffer_virt, data->buffer_phys);