IPoIB: Rewrite "if (!likely(...))" as "if (unlikely(!(...)))"
authorRoland Dreier <rolandd@cisco.com>
Thu, 18 Oct 2007 04:54:44 +0000 (21:54 -0700)
committerRoland Dreier <rolandd@cisco.com>
Thu, 18 Oct 2007 04:54:44 +0000 (21:54 -0700)
It's too hard to figure out what "!likely(...)" really means, and who
knows how compilers interpret the hint.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/ipoib/ipoib_cm.c

index 0a0dcb8..ddf0c54 100644 (file)
@@ -434,7 +434,7 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
                goto repost;
        }
 
-       if (!likely(wr_id & IPOIB_CM_RX_UPDATE_MASK)) {
+       if (unlikely(!(wr_id & IPOIB_CM_RX_UPDATE_MASK))) {
                p = wc->qp->qp_context;
                if (p && time_after_eq(jiffies, p->jiffies + IPOIB_CM_RX_UPDATE_TIME)) {
                        spin_lock_irqsave(&priv->lock, flags);