phy: rockchip: typec: Fix improper use of UCLASS_PHY
authorJonas Karlman <jonas@kwiboo.se>
Mon, 21 Jul 2025 22:07:16 +0000 (22:07 +0000)
committerKever Yang <kever.yang@rock-chips.com>
Sat, 30 Aug 2025 16:48:15 +0000 (00:48 +0800)
The Rockchip TypeC glue driver improperly present itself as a UCLASS_PHY
driver, without ever implementing the required phy_ops.

This is something that in special circumstances can lead to a NULL
pointer dereference followed by a SError crash.

Change the glue driver to use UCLASS_NOP to fix this.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/phy/rockchip/phy-rockchip-typec.c

index c48a5cd..66d1d32 100644 (file)
@@ -788,7 +788,7 @@ U_BOOT_DRIVER(rockchip_tcphy_usb3_port) = {
 
 U_BOOT_DRIVER(rockchip_typec_phy) = {
        .name   = "rockchip_typec_phy",
-       .id     = UCLASS_PHY,
+       .id     = UCLASS_NOP,
        .of_match = rockchip_typec_phy_ids,
        .probe = rockchip_tcphy_probe,
        .bind = rockchip_tcphy_bind,