phy: ti: j721e-wiz: Set error code before goto
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Wed, 6 Aug 2025 17:03:26 +0000 (18:03 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 15 Aug 2025 20:17:30 +0000 (14:17 -0600)
In j721e_wiz_probe the test for too many lanes jumps to the error exit
path without assigning an error code which could lead to calling code
silently ignoring the failure. Set the error code.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
drivers/phy/ti/phy-j721e-wiz.c

index c69a342..6e2d4bc 100644 (file)
@@ -1201,6 +1201,7 @@ static int j721e_wiz_probe(struct udevice *dev)
 
        if (num_lanes > WIZ_MAX_LANES) {
                dev_err(dev, "Cannot support %d lanes\n", num_lanes);
+               rc = -EINVAL;
                goto err_addr_to_resource;
        }