staging: unisys: unneeded NULL check
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Fri, 7 Nov 2014 12:18:34 +0000 (17:48 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Nov 2014 17:22:46 +0000 (09:22 -0800)
the NULL check for memregion is not required as it has already been
checked for NULL after kzalloc. so we can reach this part of the code
only if memregion is not NULL.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorutil/memregion_direct.c

index 26faad4..33522cc 100644 (file)
@@ -57,10 +57,8 @@ visor_memregion_create(HOSTADDRESS physaddr, ulong nbytes)
        rc = memregion;
 cleanup:
        if (rc == NULL) {
-               if (memregion != NULL) {
-                       visor_memregion_destroy(memregion);
-                       memregion = NULL;
-               }
+               visor_memregion_destroy(memregion);
+               memregion = NULL;
        }
        return rc;
 }