drm/nouveau: Put back the old 2-messages I2C slave test.
authorFrancisco Jerez <currojerez@riseup.net>
Fri, 23 Jul 2010 21:17:57 +0000 (23:17 +0200)
committerBen Skeggs <bskeggs@redhat.com>
Mon, 26 Jul 2010 01:43:31 +0000 (11:43 +1000)
I was hoping we could detect I2C devices at a given address without
actually writing data into them, but apparently some DDC slaves get
confused with 0-bytes transactions. Put the good old test back.

Reported-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Francisco Jerez <currojerez@riseup.net>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nouveau_i2c.c

index 97ba89e..5588e66 100644 (file)
@@ -281,12 +281,23 @@ nouveau_i2c_find(struct drm_device *dev, int index)
 bool
 nouveau_probe_i2c_addr(struct nouveau_i2c_chan *i2c, int addr)
 {
-       struct i2c_msg msg = {
-               .addr = addr,
-               .len = 0,
+       uint8_t buf[] = { 0 };
+       struct i2c_msg msgs[] = {
+               {
+                       .addr = addr,
+                       .flags = 0,
+                       .len = 1,
+                       .buf = buf,
+               },
+               {
+                       .addr = addr,
+                       .flags = I2C_M_RD,
+                       .len = 1,
+                       .buf = buf,
+               }
        };
 
-       return i2c_transfer(&i2c->adapter, &msg, 1) == 1;
+       return i2c_transfer(&i2c->adapter, msgs, 2) == 2;
 }
 
 int