[ARM] fix AT91 include loops
authorRussell King <rmk@dyn-67.arm.linux.org.uk>
Sun, 1 Jun 2008 10:19:33 +0000 (11:19 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 1 Jun 2008 10:19:54 +0000 (11:19 +0100)
AT91 has one include loop in its header files:

  include/asm-arm/io.h <- include/asm-arm/arch-at91/io.h <-
   include/asm-arm/io.h

Circular include dependencies are dangerous since they can result in
inconsistent definitions being provided to other code, especially if
'#ifndef' constructs are used.

Solve this by removing the offending includes.  Built tested using my
AT91 configuration.

Acked-by: Andrew Victor <linux@maxim.org.za>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
include/asm-arm/arch-at91/io.h

index 80073fd..f8beaa2 100644 (file)
@@ -21,8 +21,6 @@
 #ifndef __ASM_ARCH_IO_H
 #define __ASM_ARCH_IO_H
 
-#include <asm/io.h>
-
 #define IO_SPACE_LIMIT         0xFFFFFFFF
 
 #define __io(a)                        ((void __iomem *)(a))