rtlwifi: Align private space in rtl_priv struct
authorLarry Finger <Larry.Finger@lwfinger.net>
Thu, 19 Sep 2013 02:21:35 +0000 (21:21 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:06 +0000 (21:06 +0100)
commit 60ce314d1750fef843e9db70050e09e49f838b69 upstream.

The private array at the end of the rtl_priv struct is not aligned.
On ARM architecture, this causes an alignment trap and is fixed by aligning
that array with __align(sizeof(void *)). That should properly align that
space according to the requirements of all architectures.

Reported-by: Jason Andrews <jasona@cadence.com>
Tested-by: Jason Andrews <jasona@cadence.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/rtlwifi/wifi.h

index deb87e9..82baaa2 100644 (file)
@@ -1630,7 +1630,7 @@ struct rtl_priv {
           that it points to the data allocated
           beyond  this structure like:
           rtl_pci_priv or rtl_usb_priv */
-       u8 priv[0];
+       u8 priv[0] __aligned(sizeof(void *));
 };
 
 #define rtl_priv(hw)           (((struct rtl_priv *)(hw)->priv))