git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f858275
)
video: uvesafb: Deletion of an unnecessary check before the function call "uvesafb_free"
author
Markus Elfring
<elfring@users.sourceforge.net>
Sun, 23 Nov 2014 10:00:26 +0000
(11:00 +0100)
committer
Tomi Valkeinen
<tomi.valkeinen@ti.com>
Thu, 4 Dec 2014 14:16:01 +0000
(16:16 +0200)
The uvesafb_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/uvesafb.c
patch
|
blob
|
history
diff --git
a/drivers/video/fbdev/uvesafb.c
b/drivers/video/fbdev/uvesafb.c
index
509d452
..
f718627
100644
(file)
--- a/
drivers/video/fbdev/uvesafb.c
+++ b/
drivers/video/fbdev/uvesafb.c
@@
-1219,8
+1219,7
@@
static int uvesafb_release(struct fb_info *info, int user)
uvesafb_vbe_state_restore(par, par->vbe_state_orig);
out:
atomic_dec(&par->ref_count);
- if (task)
- uvesafb_free(task);
+ uvesafb_free(task);
return 0;
}