]> git.openpandora.org Git - pandora-kernel.git/commitdiff
drm/i915/bdw: don't try to check IPS state on BDW v2
authorJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 7 Jan 2014 21:30:45 +0000 (13:30 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 8 Jan 2014 14:48:57 +0000 (15:48 +0100)
According to Art, we don't have a way to read back the state reliably at
runtime, through the control reg or the mailbox, at least not without risking
disabling it again.  So drop the readout and checking on BDW.

v2: drop TODO comment (Paulo)
    move POSTING_READ of control reg under HSW branch in disable (Paulo)
    always report IPS as enabled on BDW (Paulo)

References: https://bugs.freedesktop.org/show_bug.cgi?id=71906
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_debugfs.c
drivers/gpu/drm/i915/intel_display.c

index 6fe7934b2894ef29aebf94795917d385e72a1522..16e8e09bbdd69a2f212739049e7e330a5f091a61 100644 (file)
@@ -1357,7 +1357,7 @@ static int i915_ips_status(struct seq_file *m, void *unused)
                return 0;
        }
 
-       if (I915_READ(IPS_CTL) & IPS_ENABLE)
+       if (IS_BROADWELL(dev) || I915_READ(IPS_CTL) & IPS_ENABLE)
                seq_puts(m, "enabled\n");
        else
                seq_puts(m, "disabled\n");
Simple merge