KVM: MMU: only write protect mappings at pagetable level
authorMarcelo Tosatti <mtosatti@redhat.com>
Wed, 22 Dec 2010 11:01:57 +0000 (09:01 -0200)
committerAvi Kivity <avi@redhat.com>
Wed, 12 Jan 2011 09:31:13 +0000 (11:31 +0200)
If a pagetable contains a writeable large spte, all of its sptes will be
write protected, including non-leaf ones, leading to endless pagefaults.

Do not write protect pages above PT_PAGE_TABLE_LEVEL, as the spte fault
paths assume non-leaf sptes are writable.

Tested-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
arch/x86/kvm/mmu.c

index b77a5ba..a2127f8 100644 (file)
@@ -3445,6 +3445,9 @@ void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot)
                if (!test_bit(slot, sp->slot_bitmap))
                        continue;
 
+               if (sp->role.level != PT_PAGE_TABLE_LEVEL)
+                       continue;
+
                pt = sp->spt;
                for (i = 0; i < PT64_ENT_PER_PAGE; ++i)
                        /* avoid RMW */