phy: rockchip: naneng-combphy: Fix Generic PHY reference counting
authorJonas Karlman <jonas@kwiboo.se>
Mon, 21 Jul 2025 22:07:12 +0000 (22:07 +0000)
committerKever Yang <kever.yang@rock-chips.com>
Sat, 30 Aug 2025 16:48:15 +0000 (00:48 +0800)
Generic PHY reference counting helps ensure driver ops for init/exit and
power on/off are called at correct state. For this to work the PHY
driver must initialize PHY-id to a persistent value in of_xlate ops.

The Rockchip COMBPHY driver does not initialize the PHY-id field, this
typically lead to use of unshared reference counting among different
struct phy instances.

Initialize the PHY-id in of_xlate ops to ensure use of shared reference
counting among all struct phy instances.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/phy/rockchip/phy-rockchip-naneng-combphy.c

index 6d8d107..a66be06 100644 (file)
@@ -224,6 +224,7 @@ static int rockchip_combphy_xlate(struct phy *phy, struct ofnode_phandle_args *a
                return -EINVAL;
        }
 
+       phy->id = priv->id;
        priv->mode = args->args[0];
 
        return 0;