usb: usb-uclass.c: Drop le16_to_cpu() as values are already swapped
authorStefan Roese <sr@denx.de>
Tue, 21 Jul 2020 08:46:04 +0000 (10:46 +0200)
committerMarek Vasut <marex@denx.de>
Wed, 5 Aug 2020 07:30:46 +0000 (09:30 +0200)
These values are already swapped to CPU endianess, so swapping them
again is a bug. Let's remove the swap here instead.

Signed-off-by: Stefan Roese <sr@denx.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Marek Vasut <marex@denx.de>
drivers/usb/host/usb-uclass.c

index f42c062..e5dda79 100644 (file)
@@ -416,21 +416,21 @@ static int usb_match_device(const struct usb_device_descriptor *desc,
                            const struct usb_device_id *id)
 {
        if ((id->match_flags & USB_DEVICE_ID_MATCH_VENDOR) &&
-           id->idVendor != le16_to_cpu(desc->idVendor))
+           id->idVendor != desc->idVendor)
                return 0;
 
        if ((id->match_flags & USB_DEVICE_ID_MATCH_PRODUCT) &&
-           id->idProduct != le16_to_cpu(desc->idProduct))
+           id->idProduct != desc->idProduct)
                return 0;
 
        /* No need to test id->bcdDevice_lo != 0, since 0 is never
           greater than any unsigned number. */
        if ((id->match_flags & USB_DEVICE_ID_MATCH_DEV_LO) &&
-           (id->bcdDevice_lo > le16_to_cpu(desc->bcdDevice)))
+           (id->bcdDevice_lo > desc->bcdDevice))
                return 0;
 
        if ((id->match_flags & USB_DEVICE_ID_MATCH_DEV_HI) &&
-           (id->bcdDevice_hi < le16_to_cpu(desc->bcdDevice)))
+           (id->bcdDevice_hi < desc->bcdDevice))
                return 0;
 
        if ((id->match_flags & USB_DEVICE_ID_MATCH_DEV_CLASS) &&