i2c: imx+mxs: Use the preferred form for passing a size of a struct
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 7 Nov 2014 02:44:34 +0000 (00:44 -0200)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 10 Nov 2014 08:34:54 +0000 (09:34 +0100)
According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommeded.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-imx.c
drivers/i2c/busses/i2c-mxs.c

index e9fb7cf..3cbc092 100644 (file)
@@ -668,8 +668,7 @@ static int i2c_imx_probe(struct platform_device *pdev)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       i2c_imx = devm_kzalloc(&pdev->dev, sizeof(struct imx_i2c_struct),
-                               GFP_KERNEL);
+       i2c_imx = devm_kzalloc(&pdev->dev, sizeof(*i2c_imx), GFP_KERNEL);
        if (!i2c_imx)
                return -ENOMEM;
 
index 07e1be6..3e7893a 100644 (file)
@@ -811,7 +811,7 @@ static int mxs_i2c_probe(struct platform_device *pdev)
        struct resource *res;
        int err, irq;
 
-       i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL);
+       i2c = devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL);
        if (!i2c)
                return -ENOMEM;