crypto: jitterentropy - Delete unnecessary checks before the function call "kzfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 23 Jun 2015 20:30:21 +0000 (22:30 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 25 Jun 2015 15:18:33 +0000 (23:18 +0800)
The kzfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/jitterentropy.c

index 6dfb220..acf44b2 100644 (file)
@@ -653,11 +653,9 @@ struct rand_data *jent_entropy_collector_alloc(unsigned int osr,
 
 void jent_entropy_collector_free(struct rand_data *entropy_collector)
 {
-       if (entropy_collector->mem)
-               jent_zfree(entropy_collector->mem);
+       jent_zfree(entropy_collector->mem);
        entropy_collector->mem = NULL;
-       if (entropy_collector)
-               jent_zfree(entropy_collector);
+       jent_zfree(entropy_collector);
        entropy_collector = NULL;
 }