drm/i915/lvds: Remove busy wait for powering up the panel.
authorChris Wilson <chris@chris-wilson.co.uk>
Sun, 12 Sep 2010 12:07:25 +0000 (13:07 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Sun, 12 Sep 2010 12:24:31 +0000 (13:24 +0100)
We just assume that it will happen in a timely manner. A variant of this
patch was first written and tested by Arjan van de Van.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_lvds.c

index f533169..9089604 100644 (file)
@@ -84,17 +84,13 @@ static void intel_lvds_set_power(struct drm_device *dev, bool on)
        if (on) {
                I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
                I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
-               if (wait_for(I915_READ(status_reg) & PP_ON, 1000))
-                       DRM_ERROR("timed out waiting to enable LVDS pipe");
-
                intel_panel_set_backlight(dev, dev_priv->backlight_level);
        } else {
                intel_panel_set_backlight(dev, 0);
-
                I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
                I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
-               POSTING_READ(lvds_reg);
        }
+       POSTING_READ(lvds_reg);
 }
 
 static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)