mmc: sdhci: Fix tuning timer incorrect setting when suspending host
authorAaron Lu <aaron.lu@amd.com>
Wed, 28 Dec 2011 03:11:12 +0000 (11:11 +0800)
committerChris Ball <cjb@laptop.org>
Thu, 12 Jan 2012 20:16:55 +0000 (15:16 -0500)
When suspending host, the tuning timer shoule be deactivated.
And the HOST_NEEDS_TUNING flag should be set after tuning timer is
deactivated.

Signed-off-by: Philip Rakity <prakity@marvell.com>
Signed-off-by: Aaron Lu <aaron.lu@amd.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c

index e062997..988ae06 100644 (file)
@@ -2356,9 +2356,8 @@ int sdhci_suspend_host(struct sdhci_host *host)
        /* Disable tuning since we are suspending */
        if (host->version >= SDHCI_SPEC_300 && host->tuning_count &&
            host->tuning_mode == SDHCI_TUNING_MODE_1) {
+               del_timer_sync(&host->tuning_timer);
                host->flags &= ~SDHCI_NEEDS_RETUNING;
-               mod_timer(&host->tuning_timer, jiffies +
-                       host->tuning_count * HZ);
        }
 
        ret = mmc_suspend_host(host->mmc);