greth: fall through to common return statement on error
authorSimon Horman <horms@verge.net.au>
Thu, 25 Feb 2010 13:50:19 +0000 (13:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Feb 2010 12:18:43 +0000 (04:18 -0800)
There doesn't seem to be any reason to explicitly return
NETDEV_TX_OK as err is set to NETDEV_TX_OK in all cases that
reach this point.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/greth.c

index d75b461..2b9c1cb 100644 (file)
@@ -560,8 +560,6 @@ map_error:
        if (net_ratelimit())
                dev_warn(greth->dev, "Could not create TX DMA mapping\n");
        dev_kfree_skb(skb);
-       return NETDEV_TX_OK;
-
 out:
        return err;
 }