mmc: octeontx_hsmmc: Remove impossible test
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Thu, 31 Jul 2025 10:51:22 +0000 (11:51 +0100)
committerStefan Roese <stefan.roese@mailbox.org>
Mon, 13 Oct 2025 14:13:21 +0000 (16:13 +0200)
In octeontx_mmc_io_drive_setup drive and slew are tested for being less
than 0 but they are declared as uint fields so this test must always
fail. Just remove the test.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
drivers/mmc/octeontx_hsmmc.c

index ffc8d4c..bb4fb29 100644 (file)
@@ -2828,9 +2828,6 @@ static void octeontx_mmc_io_drive_setup(struct mmc *mmc)
                struct octeontx_mmc_slot *slot = mmc_to_slot(mmc);
                union mio_emm_io_ctl io_ctl;
 
-               if (slot->drive < 0 || slot->slew < 0)
-                       return;
-
                io_ctl.u = 0;
                io_ctl.s.drive = slot->drive;
                io_ctl.s.slew = slot->slew;