Staging: rtl8192e: rtl8192e: Merges two lines of code and removes unused variable
authorMahati Chamarthy <mahati.chamarthy@gmail.com>
Sun, 21 Sep 2014 13:17:46 +0000 (18:47 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Sep 2014 20:51:03 +0000 (13:51 -0700)
This patch merges an assignment with an immediately following return of
the assigned variable. It also removes a variable that becomes unused due to this transformation.
The following Coccinelle semantic patch was used to make this transformation:

@@
expression ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

@@
identifier ret;
type t;
identifier c;
@@

-t ret = c;
 ... when != ret
     when strict

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c

index f0b150f..a1ecdff 100644 (file)
@@ -85,12 +85,9 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
 bool PHY_RF8256_Config(struct net_device *dev)
 {
        struct r8192_priv *priv = rtllib_priv(dev);
-       bool rtStatus = true;
 
        priv->NumTotalRFPath = RTL819X_TOTAL_RF_PATH;
-       rtStatus = phy_RF8256_Config_ParaFile(dev);
-
-       return rtStatus;
+       return phy_RF8256_Config_ParaFile(dev);
 }
 
 bool phy_RF8256_Config_ParaFile(struct net_device *dev)