git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
51f0bc7
)
netfilter: nfnetlink_log: fix silly refcount leak
author
Alexey Dobriyan
<adobriyan@gmail.com>
Fri, 26 Feb 2010 16:48:40 +0000
(17:48 +0100)
committer
Patrick McHardy
<kaber@trash.net>
Fri, 26 Feb 2010 16:48:40 +0000
(17:48 +0100)
Quick fix for memory/module refcount leak.
Reference count of listener instance never reaches 0.
Start/stop of ulogd2 is enough to trigger this bug!
Now, refcounting there looks very fishy in particular this code:
if (!try_module_get(THIS_MODULE)) {
...
and creation of listener instance with refcount 2,
so it may very well be ripped and redone. :-)
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
net/netfilter/nfnetlink_log.c
patch
|
blob
|
history
diff --cc
net/netfilter/nfnetlink_log.c
Simple merge