xen/pciback: Disable MSI/MSI-X when reseting a device
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 3 Mar 2010 18:38:43 +0000 (13:38 -0500)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 20 Jul 2011 00:58:31 +0000 (20:58 -0400)
In cases where the guest is abruptly killed and has not disabled
MSI/MSI-X interrupts we want to do it for it.

Otherwise when the guest is started up and enables MSI, we would
get a WARN() that the device already had been enabled.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/xen/xen-pciback/pciback_ops.c

index 2b9a93e..011db67 100644 (file)
@@ -23,6 +23,14 @@ void pciback_reset_device(struct pci_dev *dev)
 
        /* Disable devices (but not bridges) */
        if (dev->hdr_type == PCI_HEADER_TYPE_NORMAL) {
+#ifdef CONFIG_PCI_MSI
+               /* The guest could have been abruptly killed without
+                * disabling MSI/MSI-X interrupts.*/
+               if (dev->msix_enabled)
+                       pci_disable_msix(dev);
+               if (dev->msi_enabled)
+                       pci_disable_msi(dev);
+#endif
                pci_disable_device(dev);
 
                pci_write_config_word(dev, PCI_COMMAND, 0);