Input: fix potential overflows in driver/input/touchscreen

Change all sprintfs into snprintfs to make sure we won't stomp on
data adjacent to our buffers.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

diff --git a/drivers/input/touchscreen/gunze.c b/drivers/input/touchscreen/gunze.c
index 466da19..b769b21 100644 (file)
--- a/drivers/input/touchscreen/gunze.c
+++ b/drivers/input/touchscreen/gunze.c
@@ -129,7 +129,7 @@ static int gunze_connect(struct serio *serio, struct serio_driver *drv)
 
        gunze->serio = serio;
        gunze->dev = input_dev;
-       sprintf(gunze->phys, "%s/input0", serio->phys);
+       snprintf(gunze->phys, sizeof(serio->phys), "%s/input0", serio->phys);
 
        input_dev->private = gunze;
        input_dev->name = "Gunze AHL-51S TouchScreen";

diff --git a/drivers/input/touchscreen/h3600_ts_input.c b/drivers/input/touchscreen/h3600_ts_input.c
index a595d38..2de2139 100644 (file)
--- a/drivers/input/touchscreen/h3600_ts_input.c
+++ b/drivers/input/touchscreen/h3600_ts_input.c
@@ -363,7 +363,7 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv)
 
        ts->serio = serio;
        ts->dev = input_dev;
-       sprintf(ts->phys, "%s/input0", serio->phys);
+       snprintf(ts->phys, sizeof(ts->phys), "%s/input0", serio->phys);
 
        input_dev->name = "H3600 TouchScreen";
        input_dev->phys = ts->phys;

diff --git a/drivers/input/touchscreen/mtouch.c b/drivers/input/touchscreen/mtouch.c
index 1d0d37e..8647a90 100644 (file)
--- a/drivers/input/touchscreen/mtouch.c
+++ b/drivers/input/touchscreen/mtouch.c
@@ -143,7 +143,7 @@ static int mtouch_connect(struct serio *serio, struct serio_driver *drv)
 
        mtouch->serio = serio;
        mtouch->dev = input_dev;
-       sprintf(mtouch->phys, "%s/input0", serio->phys);
+       snprintf(mtouch->phys, sizeof(mtouch->phys), "%s/input0", serio->phys);
 
        input_dev->private = mtouch;
        input_dev->name = "MicroTouch Serial TouchScreen";