staging: ozwpan: Deletion of unnecessary checks before the function call "oz_free_urb...
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 25 Nov 2014 15:51:08 +0000 (16:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2014 22:00:22 +0000 (14:00 -0800)
The oz_free_urb_link() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ozwpan/ozhcd.c

index 27217d7..057632c 100644 (file)
@@ -354,8 +354,7 @@ static void oz_complete_urb(struct usb_hcd *hcd, struct urb *urb,
        }
        spin_lock(&g_tasklet_lock);
        spin_unlock_irqrestore(&g_tasklet_lock, irq_state);
-       if (cancel_urbl)
-               oz_free_urb_link(cancel_urbl);
+       oz_free_urb_link(cancel_urbl);
 }
 
 /*
@@ -523,8 +522,7 @@ static int oz_dequeue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
                }
        }
        spin_unlock_bh(&port->ozhcd->hcd_lock);
-       if (urbl)
-               oz_free_urb_link(urbl);
+       oz_free_urb_link(urbl);
        return urbl ? 0 : -EIDRM;
 }