tipc: Eliminate useless check when network address is assigned
authorAllan Stephens <allan.stephens@windriver.com>
Fri, 14 Oct 2011 18:42:25 +0000 (14:42 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Tue, 27 Dec 2011 16:33:46 +0000 (11:33 -0500)
Gets rid of an unnecessary check in the routine that updates the port id
of a node's name publications when the node is assigned a network address,
since the routine is only invoked if the new address is different from
the existing one.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/tipc/name_distr.c

index b7ca1bd..be8306f 100644 (file)
@@ -322,10 +322,9 @@ void tipc_named_recv(struct sk_buff *buf)
 /**
  * tipc_named_reinit - re-initialize local publication list
  *
- * This routine is called whenever TIPC networking is (re)enabled.
+ * This routine is called whenever TIPC networking is enabled.
  * All existing publications by this node that have "cluster" or "zone" scope
- * are updated to reflect the node's current network address.
- * (If the node's address is unchanged, the update loop terminates immediately.)
+ * are updated to reflect the node's new network address.
  */
 
 void tipc_named_reinit(void)
@@ -333,10 +332,9 @@ void tipc_named_reinit(void)
        struct publication *publ;
 
        write_lock_bh(&tipc_nametbl_lock);
-       list_for_each_entry(publ, &publ_root, local_list) {
-               if (publ->node == tipc_own_addr)
-                       break;
+
+       list_for_each_entry(publ, &publ_root, local_list)
                publ->node = tipc_own_addr;
-       }
+
        write_unlock_bh(&tipc_nametbl_lock);
 }