drm/cma-helper: fixup compilation
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 19 Feb 2013 10:18:04 +0000 (11:18 +0100)
committerDave Airlie <airlied@redhat.com>
Tue, 19 Feb 2013 22:42:24 +0000 (08:42 +1000)
/me grabs a few brown paper bags

So it looks like I've broken compilation in

commit 6aed8ec3f76a22217c9ae183d32b1aa990bed069
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Sun Jan 20 17:32:21 2013 +0100

    drm: review locking for drm_fb_helper_restore_fbdev_mode

Fix it up again.

v2: Only deref fbdev_cma once we're sure it's non-NULL, noticed by
Thierry Reding.

Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_fb_cma_helper.c

index e851658..1c8549d 100644 (file)
@@ -377,10 +377,13 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini);
  */
 void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma)
 {
-       drm_modeset_lock_all(dev);
-       if (fbdev_cma)
+       if (fbdev_cma) {
+               struct drm_device *dev = fbdev_cma->fb_helper.dev;
+
+               drm_modeset_lock_all(dev);
                drm_fb_helper_restore_fbdev_mode(&fbdev_cma->fb_helper);
-       drm_modeset_unlock_all(dev);
+               drm_modeset_unlock_all(dev);
+       }
 }
 EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode);