KVM: VMX: When emulating on invalid vmx state, don't return to userspace unnecessarily
authorAvi Kivity <avi@redhat.com>
Mon, 5 Jan 2009 10:10:54 +0000 (12:10 +0200)
committerAvi Kivity <avi@redhat.com>
Tue, 24 Mar 2009 09:03:00 +0000 (11:03 +0200)
If we aren't doing mmio there's no need to exit to userspace (which will
just be confused).

Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/vmx.c

index a309be6..df454de 100644 (file)
@@ -91,6 +91,7 @@ struct vcpu_vmx {
        } rmode;
        int vpid;
        bool emulation_required;
+       enum emulation_result invalid_state_emulation_result;
 
        /* Support for vnmi-less CPUs */
        int soft_vnmi_blocked;
@@ -3130,7 +3131,8 @@ static int handle_nmi_window(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
 static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
                                struct kvm_run *kvm_run)
 {
-       int err;
+       struct vcpu_vmx *vmx = to_vmx(vcpu);
+       enum emulation_result err = EMULATE_DONE;
 
        preempt_enable();
        local_irq_enable();
@@ -3154,6 +3156,8 @@ static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
 
        local_irq_disable();
        preempt_disable();
+
+       vmx->invalid_state_emulation_result = err;
 }
 
 /*
@@ -3205,7 +3209,7 @@ static int kvm_handle_exit(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
        if (vmx->emulation_required && emulate_invalid_guest_state) {
                if (guest_state_valid(vcpu))
                        vmx->emulation_required = 0;
-               return 0;
+               return vmx->invalid_state_emulation_result != EMULATE_DO_MMIO;
        }
 
        /* Access CR3 don't cause VMExit in paging mode, so we need